fix: update sysinfo and fix fd leak on linux #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
fix_system_fd_leak
branch
2 times, most recently
from
50cea01
to
c29b008
Compare
sehz
reviewed
Sep 2, 2024
| let process_name = process.name().to_str(); | ||
|
|
||
| if let Some(process_name) = process_name { | ||
| if process_name.contains("fluvio") { |
There was a problem hiding this comment.
can you make fluvio as constant?
sehz
reviewed
Sep 2, 2024
crates/fluvio-cluster/src/delete.rs
Outdated
| let mut sys = System::new(); | ||
| sys.refresh_processes(); // Only load what we need. | ||
| for process in sys.processes_by_exact_name(name) { | ||
| sys.refresh_processes(sysinfo::ProcessesToUpdate::All); // Only load what we need. |
There was a problem hiding this comment.
this seems like repeating. can you change into common util?
There was a problem hiding this comment.
Sure! I created a process mod.
sehz
approved these changes
Sep 3, 2024
fraidev
force-pushed
the
fix_system_fd_leak
branch
from
02bde02
to
7367ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sysinfo to 0.31.4 and fix file descriptor leak on Linux.
sysinfoleaks file descriptors on Linux if the limit is not set.Spu Before:
Spu After: